Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add dial constructors for all chainio structs #11

Closed
wants to merge 1 commit into from

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Oct 3, 2023

Been integrating the metrics and nodeapi with eigenDA, and it's a real pain to use our chain readers.
Sometimes I just need a simple chainreader, and I don't want to have to use the entire huge constructor.

Added one example of how we could do this, just to show what I'm thinking.

Wdyt @shrimalmadhur . Should we add these everywhere? I feel like it would be helpful.

Motivation

Solution

Open questions

@shrimalmadhur
Copy link
Collaborator

Been integrating the metrics and nodeapi with eigenDA, and it's a real pain to use our chain readers. Sometimes I just need a simple chainreader, and I don't want to have to use the entire huge constructor.

Added one example of how we could do this, just to show what I'm thinking.

Wdyt @shrimalmadhur . Should we add these everywhere? I feel like it would be helpful.

Motivation

Solution

Open questions

I think we need to think about this from overall redesign perspective, based on usage which you are finding when using eigenda. because we will keep adding new kind of construction which will result in a very messy codebase. Let's discuss holistically how we want to design construction of clients.

@samlaf
Copy link
Collaborator Author

samlaf commented Oct 5, 2023

I personally think it's better to have too many constructors than too few.

@shrimalmadhur
Copy link
Collaborator

I personally think it's better to have too many constructors than too few.

Ya I'm not against it. I think we just need to have a quick design session to figure out the correct patterns and then implement it.

@samlaf
Copy link
Collaborator Author

samlaf commented Feb 5, 2024

Closing for now as unplanned.

@samlaf samlaf closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants